Prechádzať zdrojové kódy

Added ProcessThrowsIfInvalidExtension

Piotr Czajkowski 22 hodín pred
rodič
commit
53d98ba706

+ 8 - 0
ProcessFiles/ProcessFiles.cs

@@ -15,6 +15,7 @@ namespace ProcessFiles
     public class ProcessFiles
     public class ProcessFiles
     {
     {
         private readonly List<string> errors = [];
         private readonly List<string> errors = [];
+        private  readonly  List<char> invalidCharactersForExtension = ['?', '*'];
 
 
         private Result WhatIsIt(string path)
         private Result WhatIsIt(string path)
         {
         {
@@ -120,6 +121,10 @@ namespace ProcessFiles
             foreach (var file in files.Distinct())
             foreach (var file in files.Distinct())
                 ProcessFile(file, fileExtensions, action);
                 ProcessFile(file, fileExtensions, action);
         }
         }
+        
+        private bool ValidExtension(string fileExtension) => !invalidCharactersForExtension.Any(fileExtension.Contains);
+        
+        private List<string> GetInvalidExtensions(string [] fileExtensions) => [.. fileExtensions.Where(x => !ValidExtension(x))];
 
 
         public List<string> Process(IEnumerable<string> arguments, string fileExtension, Action<string> action, bool recursive = false)
         public List<string> Process(IEnumerable<string> arguments, string fileExtension, Action<string> action, bool recursive = false)
         {
         {
@@ -128,6 +133,9 @@ namespace ProcessFiles
 
 
         public List<string> Process(IEnumerable<string> arguments, string[] fileExtensions, Action<string> action, bool recursive = false)
         public List<string> Process(IEnumerable<string> arguments, string[] fileExtensions, Action<string> action, bool recursive = false)
         {
         {
+            var invalidExtensions = GetInvalidExtensions(fileExtensions);
+            if (invalidExtensions.Count > 0) throw new ArgumentException($"Following extensions contain invalid characters ({invalidCharactersForExtension}):\n{string.Join(Environment.NewLine, invalidExtensions)}");
+            
             foreach (var argument in arguments)
             foreach (var argument in arguments)
             {
             {
                 switch (WhatIsIt(argument))
                 switch (WhatIsIt(argument))

+ 9 - 1
ProcessFilesTests/ProcessFilesTests.cs

@@ -1,4 +1,5 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using System.IO;
 using System.IO;
 using System.Linq;
 using System.Linq;
 using Xunit;
 using Xunit;
@@ -190,5 +191,12 @@ namespace ProcessFilesTests
             Assert.Empty(errors);
             Assert.Empty(errors);
             Assert.Empty(result.Values.Where(x => x > 1).ToList());
             Assert.Empty(result.Values.Where(x => x > 1).ToList());
         }
         }
+        
+        [Fact]
+        public void ProcessThrowsIfInvalidExtension()
+        {
+            var test = new ProcessFiles.ProcessFiles();
+            Assert.Throws<ArgumentException>(() => test.Process([testFolder], ["t?t", "T*T"], Console.WriteLine));
+        }
     }
     }
 }
 }