Parcourir la source

Prefer to have Location in Message

Piotr Czajkowski il y a 2 mois
Parent
commit
5badcc3fa6
2 fichiers modifiés avec 2 ajouts et 4 suppressions
  1. 1 2
      ExcelORM/ExcelORM/ExcelReader.cs
  2. 1 2
      ExcelORM/ExcelORMTests/ReaderTests.cs

+ 1 - 2
ExcelORM/ExcelORM/ExcelReader.cs

@@ -53,8 +53,7 @@ public class ExcelReader : IDisposable
                 }
                 catch (ArgumentException e)
                 {
-                    e.Data.Add("Location", $"{cell.Address.ColumnLetter}{cell.Address.RowNumber} ({cell.Worksheet.Name})");
-                    throw;
+                    throw new ArgumentException($"{e.Message}\nLocation: {cell.Address.ColumnLetter}{cell.Address.RowNumber} ({cell.Worksheet.Name})", e);
                 }
             }
 

+ 1 - 2
ExcelORM/ExcelORMTests/ReaderTests.cs

@@ -116,7 +116,6 @@ public class ReaderTests
     {
         using var reader = new ExcelReader(BadDate);
         var exception = Assert.Throws<ArgumentException>(() => reader.Read<TestTypes>().ToArray());
-        Assert.True(exception.Data.Contains("Location"));
-        Assert.NotEmpty(exception.Data["Location"]?.ToString() ?? string.Empty);
+        Assert.Contains("Location", exception.Message);
     }
 }